Multiple models support #54

kenzo-tanaka · 2022-09-18T12:52:16Z

Related: #44

This change will support multiple models.

What I fixed

Accept multiple model setting by klass_names
Display multiple login forms
Pass class name by params[:as]
In controller, find model name by params[:as] and login.

Configuration

config.klass_names = ['User', 'Staff']

Demo

any_login_multiple.mov

I checked this behavior at this repository.
kenzo-tanaka/rails_sandbox#8

kenzo-tanaka · 2022-09-19T04:44:04Z

app/assets/stylesheets/any_login/application.css

-#any_login span#anylogin_back_to_user {
+#any_login span.anylogin_back_to_user {


I fixed css id to class, because some login forms would be displayed.

kenzo-tanaka · 2022-09-19T04:46:19Z

app/controllers/any_login/application_controller.rb

+    def klass
+      params[:as].constantize
+    end


This parameter is the login class (ex. User, Staff)

kenzo-tanaka · 2022-09-19T04:47:16Z

app/views/any_login/_any_login.html.erb

+
+  <span id="any_login_box">
+    <% AnyLogin.klasses.each do |klass| %>
+      <%= form_tag any_login.sign_in_path(as: klass.to_s), :method => :post, :class => 'any_login_form' do %>


Set the login class here.

kenzo-tanaka · 2022-09-19T04:51:35Z

Hello @igorkasyanchuk @rbclark , Could you review this PR ?

It was difficult to resolve conflicts on #44, so I created this new PR.

igorkasyanchuk · 2022-09-19T08:34:59Z

@kenzo-tanaka good start, but I have a question, could you please extend at least dummy/devise app with another model? I want to try it on your branch.

kenzo-tanaka · 2022-09-21T13:54:29Z

Thanks for the reply. I will try it.

kenzo-tanaka · 2022-10-19T13:18:52Z

@igorkasyanchuk
Sorry for the delay in responding.

could you please extend at least dummy/devise app with another model?

I am having trouble understanding how to proceed this.
Do I just create a new model under the test/rails_app/devise directory and fix the any_login settings?

rbclark · 2022-10-19T13:26:18Z

I am having trouble understanding how to proceed this. Do I just create a new model under the test/rails_app/devise directory and fix the any_login settings?

Correct, specifically in the test/rails_apps/devise/app/models folder. You can set it up the same way it is in your demo with a user and a staff model if you wish.

kenzo-tanaka · 2022-10-19T13:32:48Z

Thanks for the reply.
Is it possible to use the rails or rake commands in the test/rails_app/devise directory?

I get an error when I run the following commands, is there a workaround?

$ cd test/rails_apps/devise/
$ rails db:create    
rails aborted!
NameError: uninitialized constant Bundler
/Users/tanakakenzou/Documents/personal/any_login/test/rails_apps/devise/config/application.rb:7:in `<top (required)>'
/Users/tanakakenzou/Documents/personal/any_login/test/rails_apps/devise/Rakefile:4:in `require_relative'
/Users/tanakakenzou/Documents/personal/any_login/test/rails_apps/devise/Rakefile:4:in `<top (required)>'
bin/rails:4:in `<main>'

Caused by:
LoadError: cannot load such file -- rails/commands
bin/rails:4:in `<main>'
(See full trace by running task with --trace)

rbclark · 2022-10-19T13:42:33Z

Thanks for the reply. Is it possible to use the rails or rake commands in the test/rails_app/devise directory?

I get an error when I run the following commands, is there a workaround?

You just need to preface your commands with bundle exec,

➜  devise git:(master) pwd
/Documents/any_login/test/rails_apps/devise
➜  devise git:(master) bundle exec rails db:create
Database 'db/development.sqlite3' already exists
Database 'db/test.sqlite3' already exists

kenzo-tanaka · 2022-10-20T13:52:14Z

@igorkasyanchuk @rbclark
I added a new model to the devise sample app.
Please check it.

rbclark

Thanks for this! I had a few questions, mainly around the klass_name and not breaking the API for existing users.

app/views/any_login/_any_login.html.erb

rbclark · 2022-11-07T16:27:07Z

lib/any_login.rb

  mattr_accessor :klass_name
  @@klass_name = 'User'


Does this PR break the ability to use the old klass_name style? If so it's likely going to require all users to update their configuration which is going to be a breaking change. Thoughts on just using klass_name and checking whether it is an array or not in the code and then handling it accordingly?

This PR does not break klass_name style because the default value of klass_names is [@@klass_name].
I think this is simpler than klass_name, which accepts both strings and arrays.

If you want to use any_login in multiple models, you can use klass_names, and if that is not necessary, you can continue to use klass_name.

You can confirm that the klass_name style is not broken in demo apps.

test/rails_app/authlogic

test/rails_app/clearance

I just did a test in the demo devise application and it seems to confirm that klass_name is currently broken. I switched the devise demo application to use klass_name = 'Staff' and I was only presented with users and not staff:

Screen.Recording.2022-12-22.at.11.53.49.AM.mov

The reason this is happening it the klass_names is always being initialized with the default value of klass_name (which is User) and it is never taking into account the users input. The easiest way to fix this would be to just use klass_name for everything and just handle it properly if klass_name is an array.

lib/any_login/providers/authlogic.rb

rbclark · 2022-12-22T17:08:44Z

Thank you @kenzo-tanaka, this is super close to being ready to merge. The only remaining issue is the klass_name problem.

kenzo-tanaka mentioned this pull request Sep 18, 2022

Multiple models support #44

Closed

kenzo-tanaka marked this pull request as draft September 19, 2022 04:02

kenzo-tanaka commented Sep 19, 2022

View reviewed changes

kenzo-tanaka marked this pull request as ready for review September 19, 2022 04:47

kenzo-tanaka changed the title ~~[WIP]Multi models~~ Multiple models support Sep 19, 2022

kenzo-tanaka marked this pull request as draft October 20, 2022 12:46

kenzo-tanaka marked this pull request as ready for review October 20, 2022 13:49

rbclark requested changes Nov 7, 2022

View reviewed changes

This was referenced Jan 8, 2024

Ability to manage two classes #56

Open

Multiple model support updates #57

Closed

kenzo-tanaka added 11 commits January 10, 2024 14:21

Add klass names to template

6fec326

Add default value of klass names

a86b194

Get new params as for switching login class

4ff39eb

Add klasses method to any_login.rb

ba8ed2c

Display login forms

885e07e

Fix any_login_select method

c95b3e9

Add klass arg to any_login_previous_select method

93032fc

Add klass arg to current_user_information method

ca4d982

Remove log file

fa9d292

Fix default value of klass names

c8ae86d

Fix JavaScript

0fa738f

kenzo-tanaka and others added 27 commits January 10, 2024 14:21

Fix #any_login -> .any_login

c78726b

Fix CSS id to class

8c2fb9b

Remove old form

a51faae

Fix styles

a8da931

Fix prompt

6430595

Fix JavaScript

992d979

Fix login method

ac462b1

Fix devise.rb

6fced36

Fix style

228929d

Fix view to pass tests

89b45ac

Fix id to class

a04f90d

Fix tests

d6fab62

Fix styles to display all login form

d52011f

Add Staff model

bc2976e

Add devise to staff

1b36eda

Fix klass_name to klass_names

6b26c6b

Fix model

aeb9a5e

Add test staffs

3dd3a76

Fix routes

a75d80f

Fix navigation test

7fedc7c

To escape id duplication, specify id = nil

36adfab

Fix navigation test

724b127

tweak

99e1b91

Fix icon margin

b4c7f94

Update README.md

c165db5

Update README.md

9e8d627

Use existing klass_name option for both single and multi-model support

9e40d23

rbclark force-pushed the feat/customized branch from 9d13a77 to 9e40d23 Compare January 10, 2024 19:22

Remove AnyLogin.klass and utilize klasses everywhere instead.

f93cb6b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multiple models support #54

Multiple models support #54

kenzo-tanaka commented Sep 18, 2022 •

edited

Loading

kenzo-tanaka Sep 19, 2022

kenzo-tanaka Sep 19, 2022

kenzo-tanaka Sep 19, 2022

kenzo-tanaka commented Sep 19, 2022

igorkasyanchuk commented Sep 19, 2022

kenzo-tanaka commented Sep 21, 2022

kenzo-tanaka commented Oct 19, 2022 •

edited

Loading

rbclark commented Oct 19, 2022

kenzo-tanaka commented Oct 19, 2022

rbclark commented Oct 19, 2022

kenzo-tanaka commented Oct 20, 2022

rbclark left a comment

rbclark Nov 7, 2022

kenzo-tanaka Nov 28, 2022

kenzo-tanaka Nov 28, 2022

rbclark Dec 22, 2022

rbclark commented Dec 22, 2022

		#any_login span#anylogin_back_to_user {
		#any_login span.anylogin_back_to_user {

Multiple models support #54

Are you sure you want to change the base?

Multiple models support #54

Conversation

kenzo-tanaka commented Sep 18, 2022 • edited Loading

What I fixed

Configuration

Demo

kenzo-tanaka Sep 19, 2022

Choose a reason for hiding this comment

kenzo-tanaka Sep 19, 2022

Choose a reason for hiding this comment

kenzo-tanaka Sep 19, 2022

Choose a reason for hiding this comment

kenzo-tanaka commented Sep 19, 2022

igorkasyanchuk commented Sep 19, 2022

kenzo-tanaka commented Sep 21, 2022

kenzo-tanaka commented Oct 19, 2022 • edited Loading

rbclark commented Oct 19, 2022

kenzo-tanaka commented Oct 19, 2022

rbclark commented Oct 19, 2022

kenzo-tanaka commented Oct 20, 2022

rbclark left a comment

Choose a reason for hiding this comment

rbclark Nov 7, 2022

Choose a reason for hiding this comment

kenzo-tanaka Nov 28, 2022

Choose a reason for hiding this comment

kenzo-tanaka Nov 28, 2022

Choose a reason for hiding this comment

rbclark Dec 22, 2022

Choose a reason for hiding this comment

rbclark commented Dec 22, 2022

kenzo-tanaka commented Sep 18, 2022 •

edited

Loading

kenzo-tanaka commented Oct 19, 2022 •

edited

Loading